Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Product requests to fake WFO locations return 200 with empty result #1818

Open
1 task
eric-gade opened this issue Sep 24, 2024 · 0 comments
Open
1 task
Labels
Bug Something isn't working

Comments

@eric-gade
Copy link
Collaborator

Description

If you make a request for a specific product with an invalid WFO code, you still get a 200 (successful) result, just with an empty list as the result.

Example.

As a user of the API, I would expect some kind of error code response, maybe even a 404 with an explanation that the given location is invalid.

Acceptance criteria

  • Requests to product listings (like the AFD example above) return a 4xx status code for invalid locations, along with an explanation message
@eric-gade eric-gade added the Bug Something isn't working label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Development

No branches or pull requests

1 participant