Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading indicator persists after clicking back button #1323

Closed
3 tasks
partly-igor opened this issue Jun 17, 2024 · 0 comments · Fixed by #1359
Closed
3 tasks

Loading indicator persists after clicking back button #1323

partly-igor opened this issue Jun 17, 2024 · 0 comments · Fixed by #1359
Assignees
Labels
Bug Something isn't working

Comments

@partly-igor
Copy link
Collaborator

Description

After searching for a location if a user hits the browser's back button the loading indicator will display once the page is loaded. We don't want this to show because it makes it seem like the user has submitted a new search query. This happens both when the starting point is either the home page or the point forecast page.

To replicate:

  1. On the homepage of beta.weather.gov search for any location
  2. After the point forecast page loads click the browser's back button
  3. The loading indicator appears on the home page

Similarly

  1. From any point forecast page search for a different location
  2. Once the 2nd location page has loaded click the browser's back button
  3. The loading indicator appears on the first point forecast page.

Acceptance criteria

  • After searching for a location and clicking the back button, the loading indicator does not show on the resulting page (the previous one in history)
  • Tests have been implemented or modified to capture the bug
  • Changes have been tested for accessibility
@partly-igor partly-igor added the Bug Something isn't working label Jun 17, 2024
@partly-igor partly-igor added this to the Milestone 4 - Local Expertise milestone Jun 17, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants