Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #163 #164

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Fix #163 #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99e8dbc
fix warden skill id typo
whiterabbit963 Jan 1, 2024
59a9b5c
fix invalid member access in CheckSkills()
whiterabbit963 Jan 7, 2024
e556c25
fix #163, on OptionsPanel checkskills() access
whiterabbit963 Jan 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/IndexedDictionaryDe.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ function TravelDictionaries:CreateDictionaries()
wardenLocations:AddSkill("Appell im Lager des Heeres", "0x70047BFC", "Lager des Heeres (Appell)");
wardenLocations:AddSkill("Appell in Haerondir", "0x70047C23", "Haerondir (Appell)");
wardenLocations:AddSkill("Appell am Udûn-Brückenkopf", "0x7004AE1F", "Udûn-Brückenkopf (Appell)");
wardenLocations:AddSkill("Appell in Thal", "0x7004A73A", "Thal (Appell)");
wardenLocations:AddSkill("Appell in Thal", "0x7004D73A", "Thal (Appell)");
wardenLocations:AddSkill("Appell in Járnfast", "0x7004FACA", "Jarnfast (Appell)");
wardenLocations:AddSkill("Appell in Skarháld", "0x7004FACD", "Skarhald (Appell)");
wardenLocations:AddSkill("Appell im Beorningerhús", "0x70052F0A", "Beorningerhús (Appell)");
Expand Down
2 changes: 1 addition & 1 deletion src/OptionsPanel.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ function OptionsPanel:AddBoxes()

-- do the check skills
self.checkSkillsButton.Click = function(sender, args)
TravelWindow:CheckSkills(true);
self.mainWindow:CheckSkills(true);
end
end

Expand Down
2 changes: 1 addition & 1 deletion src/TravelWindow.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1153,7 +1153,7 @@ function TravelWindow:CheckSkills(report)
local newShortcut = false;
-- loop through all the shortcuts and list those those that are not learned
for i = 1, #TravelShortcuts, 1 do
local wasFound = TravelShortcuts[i].shortcut;
local wasFound = TravelShortcuts[i].found;
if (TravelWindow:FindSkill(TravelShortcuts[i])) then
if not wasFound then
newShortcut = true;
Expand Down