Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't get latest version #3

Open
BoShurik opened this issue Oct 11, 2023 · 4 comments
Open

Can't get latest version #3

BoShurik opened this issue Oct 11, 2023 · 4 comments

Comments

@BoShurik
Copy link

Because of git checkout v1.8.0 we can't get latest version from master (1.8.19 for now)

@wcsiu
Copy link
Owner

wcsiu commented Oct 23, 2023

What do you mean by 1.8.19? I could not find the tag. This repo is mainly keeping track of tag version of tdlib. If you need the latest code from tdlib, you may update the dockerfile and build it yourself. I believe it will solve your problem.

@BoShurik
Copy link
Author

The problem is that there are tags only for X.Y.0 releases, but patch releases (I.m not sure they follow semver because e.g. 1.8.0 not compatible with 1.8.19) exist without tags: tdlib/td@4ed0b23

@BoShurik
Copy link
Author

Looks like an official recommendation is to use code from HEAD, not from tags: tdlib/td#2215

@wcsiu
Copy link
Owner

wcsiu commented Oct 25, 2023

I see. However, there is no way I can make sure the dockerfile works if it just check out to master branch. It will break every time there is a new dependency added to tdlib. For a dynamic HEAD, I suppose users of this repo will have to do some customizations themselves.

Repository owner deleted a comment from tobarbaro Feb 10, 2024
Repository owner deleted a comment from tobarbaro Feb 10, 2024
Repository owner deleted a comment Mar 1, 2024
Repository owner deleted a comment from tim-tepia Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants