Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message ID not stripped from topic #1

Open
w1oko opened this issue Dec 4, 2020 · 0 comments
Open

Message ID not stripped from topic #1

w1oko opened this issue Dec 4, 2020 · 0 comments

Comments

@w1oko
Copy link

w1oko commented Dec 4, 2020

If an APRS message includes a Message ID as part of a message with acknowledgement request, the Message ID character "{" and subsequent message number are appended to the topic, making it impossible for a radio sending the message to subscribe/unsubscribe/publish to a topic. Some radios send a Message ID by default, with no option to disable.

For example, a radio attempting to subscribe to topic "antenna" might send the following packet:

N2GH>X::BROKER-15:sub:antenna{5

This would subscribe the radio to "antenna{5" - not "antenna"

A small change to the code in aprsmsg.c to ignore the Message ID "{" character and subsequent characters in the string solves this issue, e.g.:

	char * token = strtok(stuff, "{");
        printf ("%s\n", token);
        amsg_process (h, token);	
@w1oko w1oko changed the title Message ID not stripped from Message ID not stripped from topic Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant