Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for concourse #52

Open
oliveti opened this issue Mar 20, 2018 · 7 comments
Open

Support for concourse #52

oliveti opened this issue Mar 20, 2018 · 7 comments

Comments

@oliveti
Copy link

oliveti commented Mar 20, 2018

Hi,

IT seems this library does not detect concourse ci : https://concourse-ci.org

Would be great if you could support it.

Thank you.

@watson
Copy link
Owner

watson commented Mar 20, 2018

@oliveti looking through their documentation I think maybe we can check for the CONCOURSE_EXTERNAL_URL environment variable. But I'm not a 100% sure. Do you have any experience in which envs are always present?

@oliveti
Copy link
Author

oliveti commented Mar 21, 2018

This environment variable is not available in tasks (where we can run scripts) for design reasons.
Here is the list of environment variables accessible.

USER=xxx
PWD=/tmp/build/b504838c/source
HOME=xxx
https_proxy=xxx
http_proxy=xxx
no_proxy=xxx
SHLVL=1
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
_=/usr/bin/env

@watson
Copy link
Owner

watson commented Mar 21, 2018

Hmm... those are all very generic I think. Any idea of what else we can look at to detect the correct environment?

@oliveti
Copy link
Author

oliveti commented Mar 21, 2018

I do not really know what could be used here. For now I export an environment variable (CI) in my docker image.

@watson
Copy link
Owner

watson commented Mar 21, 2018

Hm, yeah the issue is probably that since this is something that people run inside their own Docker images, there's no guarantee that they export/use any environment variables that we can detect.

I've opened an issue on the Concourse GitHub repo asking for help: concourse/concourse#2105

@watson
Copy link
Owner

watson commented Mar 22, 2018

@oliveti Concourse is asking about your use-case for knowing if your code is running inside Concourse. Would you mind going to the issue and comment?

@oliveti
Copy link
Author

oliveti commented Jun 6, 2018

Hi,

Just did it here.

Thank you for the report to concourse.

@sibiraj-s sibiraj-s transferred this issue from watson/is-ci Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants