Skip to content

Injector sensor hub #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Injector sensor hub #92

wants to merge 12 commits into from

Conversation

ecslewis
Copy link

No description provided.

@StarlightDescender StarlightDescender linked an issue Feb 19, 2025 that may be closed by this pull request
Copy link

@Pdada1 Pdada1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
With a 63 mR you only get span to 2.2V when you can go to 3.3 V on the input. You can use a 91mR instead to get more span to 3.18V and use more of the measurement range.
image
Label the frequency of your oscillator
image
Don't use global labels, use net labels instead here.

@Hexamech
Copy link

  1. Invalid datasheet link for buck converter
  2. Minor but rename MC2562 to be MCP2562
  3. Can connector and Programming header footprints seem to be in an uknown library for me

@Pdada1 Pdada1 self-requested a review April 16, 2025 03:28
Copy link

@Pdada1 Pdada1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
I think your still making changes so I'm gonna wait go more thouroughly through the schematic, but something I noticed is that your connector is backwards. You wanna connect the wires to the round part (red arrow)

Might also be nice to list the sensors the board is being designed around in the analog sensor sheet.
image
Also your missing a voltage connection for this LED
image
and here
image
and here

@Pdada1 Pdada1 self-requested a review April 22, 2025 05:33
Copy link

@Pdada1 Pdada1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K, like was me and ash were talking about, this board isn't actually running any sensor on 3V3 and every other component can run on 5V supplied from the can bus. So you can get rid of the LDO (SPX 3819) and shift everything to 5V. That'll mean you have resize the current sense resistors, as well as the current limiting resistors on the LEDs, as well as replace other connections
image
voltage symbols should in general point up
Might be nice to list the sensors the board was designed for somewhere on the schematic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propulsion board issues
4 participants