-
Notifications
You must be signed in to change notification settings - Fork 2
Injector sensor hub #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your still making changes so I'm gonna wait go more thouroughly through the schematic, but something I noticed is that your connector is backwards. You wanna connect the wires to the round part (red arrow)
Might also be nice to list the sensors the board is being designed around in the analog sensor sheet.
Also your missing a voltage connection for this LED
and here
and here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
K, like was me and ash were talking about, this board isn't actually running any sensor on 3V3 and every other component can run on 5V supplied from the can bus. So you can get rid of the LDO (SPX 3819) and shift everything to 5V. That'll mean you have resize the current sense resistors, as well as the current limiting resistors on the LEDs, as well as replace other connections
voltage symbols should in general point up
Might be nice to list the sensors the board was designed for somewhere on the schematic
No description provided.