remove workaround for removedChild not working earlier

Author: dethe

docs/custom_events.md

@@ -14,9 +14,9 @@ Fired when a block is added to a script. When a block is moved, it is removed, t
 
 Fired when a block in a script is modified (i.e., it's socket values are changed).
 
-## wb-remove
+## wb-removedChild
 
-Fired when a block is removed from a script. Moving a block fires both a remove and an add event.
+Fired when a block is removed from a script. Moving a block fires both a removedChild and an add event.
 
 ## wb-delete
 
@@ -45,5 +45,3 @@ Fired when there is a change to one of the state variables (???)
 ## wb-ready
 
 Fired when all the async components (ide, stage, script) have reported in that they're ready.
-
-

js/block.js

@@ -408,13 +408,6 @@ ExpressionProto.detachedCallback = function expressionDetached(){
             sib.classList.remove('hide');
         });
     }
-    if (this.parent.localName !== 'wb-local'){
-        var blockParent = dom.closest(this.parent, 'wb-expression, wb-step, wb-context');
-        // FIXME: Is this needed or was it a workaround for wb-removedChild not firing?
-        if (blockParent){
-            Event.trigger(blockParent, 'wb-removedChild', this);
-        }
-    }
     this.parent = null;
 };
 
@@ -1346,9 +1339,6 @@ Event.registerElementsForAddRemoveEvents(workspace, 'wb-', 'wb-step, wb-context,
 Event.on(workspace, 'editor:wb-added', 'wb-expression', updateVariableType);
 Event.on(workspace, 'editor:wb-added', 'wb-context, wb-step', uniquifyVariableNames);
 Event.on(document.body, 'editor:wb-cloned', '[fn="getVariable"]', createLocalToInstanceAssociation);
-Event.on(workspace, 'editor:wb-removedChild', 'wb-contains, wb-context, wb-step, wb-expression', function(evt){
-    console.log('caught wb-removedChild: %o', evt);
-});
 
 Event.on(workspace, 'editor:click', 'wb-disclosure', toggleClosed);
 

js/widget.js

@@ -164,30 +164,5 @@ Event.on(window, 'ui:dblclick', 'wb-splitter', function(evt){
     }
 });
 
-// Observe child changes
-
-var observer = new MutationObserver(function(mutations){
-    mutations.forEach(function(mutation){
-        // send childAdded or childRemove event to parent element
-        // should I filter this to only elements (otherwise text nodes will be included)?
-        var parent = mutation.target;
-        [].slice.apply(mutation.removedNodes).forEach(function(node){
-            parent.dispatchEvent(new CustomEvent('removeChild', {
-                bubbles: true,
-                detail: node
-            }));
-        });
-        [].slice.apply(mutation.addedNodes).forEach(function(node){
-            parent.dispatchEvent(new CustomEvent('addChild', {
-                bubbles: true,
-                detail: node
-            }));
-        });
-    });
-});
-
-var config = { childList: true, subtree: true };
-
-// observer.observe(document.body, config);
 
 })();