-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
there is no such prop for hiding and showing the prop [feature request] #22
Comments
Hi @dharmendrashah, this feature will be released soon. What do you say @watadarkstar? I can start working on this right away. |
@murageden Happy to have you add a prop that lets the user hide the component. Like so:
If that's what is being asked? |
Feature request. Sure. I will make a PR as soon as I get on my desk. Thank you @watadarkstar😊 |
@dharmendrashah Do you mean hiding the component? Because you said "hiding this prop" but that doesn't make sense to me. |
Yeah, obviously he means the whole view/ Component. I understand @dharmendrashah 's limbo. But we want to keep the library as light as possible, that's why we are making just the loader. The functionality for the loader is considered external to the loader. This feature will only be limited to allowing: make the component shown/hidden. It won't include things like timing the showing/hiding states. |
@watadarkstar, I raised a request for this feature, kindly review and merge. @dharmendrashah this should be fixed after the merge. This issue should be marked as closed now, @watadarkstar. |
This has been merged in as of PR #25 |
i want to add this in my chat application but i didn't see any options for showing and hiding this prop i can do this by our own side but it will be very helpful that it will be the initiated prop option in this modules.
The text was updated successfully, but these errors were encountered: