You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Oops, I have not see this. In this case this is fine as we use std::deque, but still I should have think about this before :) I guess I need some tests that causes stack memory grow here and then ASan should find the bug, if it ever happen.
For me in #312 control stack using Stack often reallocates even when growing from size 1 to 2 (in Debug).
For example if order of frame updating and push is reversed here, some unit tests are failing (e.g. execute_control.br_table_as_return)
I checked all 3 cases in block, loop and if. If frame used after control_stack.push() and std::vector used as std::stack backend, all are causing ASan failures when running execute_control test suite.
Oops, I have not see this. In this case this is fine as we use
std::deque
, but still I should have think about this before :) I guess I need some tests that causes stack memory grow here and then ASan should find the bug, if it ever happen.Originally posted by @chfast in #319
The text was updated successfully, but these errors were encountered: