From 4db785750511eb95096d86aa752b43bdbb3675a0 Mon Sep 17 00:00:00 2001
From: Christoph Herzog <chris@theduke.at>
Date: Mon, 3 Jun 2024 22:17:51 +0200
Subject: [PATCH] chore: Minor tweaks to the HttpRequest definitions

For better serialization behaviour.
---
 lib/config/src/app/http.rs | 6 ++++--
 lib/config/src/app/mod.rs  | 1 +
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/lib/config/src/app/http.rs b/lib/config/src/app/http.rs
index 69e454d4b06..15e85ade592 100644
--- a/lib/config/src/app/http.rs
+++ b/lib/config/src/app/http.rs
@@ -13,6 +13,7 @@ pub struct HttpRequest {
     pub method: Option<String>,
 
     /// Request body as a string.
+    #[serde(skip_serializing_if = "Option::is_none")]
     pub body: Option<String>,
 
     /// Request timeout.
@@ -21,6 +22,7 @@ pub struct HttpRequest {
     #[serde(skip_serializing_if = "Option::is_none")]
     pub timeout: Option<String>,
 
+    #[serde(skip_serializing_if = "Option::is_none")]
     pub expect: Option<HttpRequestExpect>,
 }
 
@@ -30,8 +32,8 @@ pub struct HttpRequest {
 )]
 pub struct HttpRequestExpect {
     /// Expected HTTP status codes.
-    #[serde(skip_serializing_if = "Vec::is_empty")]
-    pub status_codes: Vec<u16>,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub status_codes: Option<Vec<u16>>,
 
     /// Text that must be present in the response body.
     #[serde(skip_serializing_if = "Option::is_none")]
diff --git a/lib/config/src/app/mod.rs b/lib/config/src/app/mod.rs
index 60c856fa926..5052e655bfc 100644
--- a/lib/config/src/app/mod.rs
+++ b/lib/config/src/app/mod.rs
@@ -193,6 +193,7 @@ pub struct AppConfigCapabilityMapV1 {
     pub memory: Option<AppConfigCapabilityMemoryV1>,
 
     /// Enables app bootstrapping with startup snapshots.
+    #[serde(skip_serializing_if = "Option::is_none")]
     pub instaboot: Option<AppConfigCapabilityInstaBootV1>,
 }