Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(c-api) Update cbindgen to 0.19 #2446

Merged
merged 3 commits into from
Jul 8, 2021

Conversation

Hywan
Copy link
Contributor

@Hywan Hywan commented Jul 1, 2021

Description

This patch updates cbindgen to 0.19.

Review

  • Add a short description of the change to the CHANGELOG.md file not necessary

@Hywan Hywan added 🎉 enhancement New feature! 📦 lib-c-api About wasmer-c-api labels Jul 1, 2021
@Hywan Hywan self-assigned this Jul 1, 2021
@Hywan
Copy link
Contributor Author

Hywan commented Jul 1, 2021

bors try

bors bot added a commit that referenced this pull request Jul 1, 2021
@bors
Copy link
Contributor

bors bot commented Jul 1, 2021

try

Build failed:

@syrusakbary
Copy link
Member

Assuming it was a flaky test. Re-doing:

bors try

bors bot added a commit that referenced this pull request Jul 1, 2021
@bors
Copy link
Contributor

bors bot commented Jul 1, 2021

try

Build failed:

@syrusakbary
Copy link
Member

Noope, the error seem to be triggered by the last update

@syrusakbary
Copy link
Member

Weird #2442 is also failing for the same reason, but it didn't touch any of this code. I suspect master might be failing for the same reason

@Hywan
Copy link
Contributor Author

Hywan commented Jul 2, 2021

bors try

bors bot added a commit that referenced this pull request Jul 2, 2021
@bors
Copy link
Contributor

bors bot commented Jul 2, 2021

try

Build failed:

@wasmerio wasmerio deleted a comment from bors bot Jul 6, 2021
@Hywan
Copy link
Contributor Author

Hywan commented Jul 6, 2021

bors try-

@syrusakbary
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 7, 2021

👎 Rejected by too few approved reviews

@syrusakbary
Copy link
Member

bors r+

@Hywan Hywan merged commit d450ff5 into wasmerio:master Jul 8, 2021
@Hywan
Copy link
Contributor Author

Hywan commented Jul 8, 2021

Merging by hand because the patch touches a Github workflow file, and Bors refuses to run in this case :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 enhancement New feature! 📦 lib-c-api About wasmer-c-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants