Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASI state serialization doesn't preserve unread stdin bytes #754

Closed
MarkMcCaskey opened this issue Sep 4, 2019 · 1 comment
Closed
Assignees
Labels
bug Something isn't working 📦 lib-wasi About wasmer-wasi

Comments

@MarkMcCaskey
Copy link
Contributor

MarkMcCaskey commented Sep 4, 2019

When serializing WASI state we ignore unread stdin bytes.

Maybe this is the correct behavior? This needs design and more thought before we can fix it.

See #726 for more context

@MarkMcCaskey MarkMcCaskey added the bug Something isn't working label Sep 4, 2019
@MarkMcCaskey MarkMcCaskey self-assigned this Sep 4, 2019
@Hywan
Copy link
Contributor

Hywan commented Jul 15, 2021

I believe it is the correct and expected behavior. Serializing is not used to “pause” the runtime in this context, but rather to “save” the compiled module, to later re-instantiating it quickly. Keeping the stdin bytes would be a terrible behavior in this context because the execution context would be totally different. I'm closing this issue :-).

@Hywan Hywan closed this as completed Jul 15, 2021
@Hywan Hywan added the 📦 lib-wasi About wasmer-wasi label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 📦 lib-wasi About wasmer-wasi
Projects
None yet
Development

No branches or pull requests

2 participants