Return compile error (llvm) for setting immutable global #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjfish
requested review from
losfair,
MarkMcCaskey,
nlewycky and
syrusakbary
as code owners
MarkMcCaskey
approved these changes
Aug 14, 2019
| @@ -1151,7 +1151,9 @@ impl FunctionCodeGenerator<CodegenError> for LLVMFunctionCodeGenerator { | |||
| builder.build_store(ptr_to_value, value); | |||
| } | |||
| GlobalCache::Const { value: _ } => { | |||
| unreachable!("cannot set non-mutable globals") | |||
| return Err(CodegenError { | |||
| message: "global is immutable".to_string(), | |||
There was a problem hiding this comment.
It'd be nice to include more information here if it's available, like what global and what value maybe. To make debugging easier
There was a problem hiding this comment.
I like having more context, I'll start thinking about this as I see more messages.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 14, 2019
674: Return compile error (llvm) for setting immutable global r=bjfish a=bjfish Co-authored-by: Brandon Fish <[email protected]>
Hywan
added
🎉 enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.