wasmer-c-api: error visibility changes #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* error.rs - changing `update_last_error` visibility to `pub`. * error.rs - changing `CApiError` `msg` field visibility to `pub`.
… making `wasmer_byte_array` fields `public` wasmerio#589")
YaronWittenstein
changed the title
YaronWittenstein
changed the title
bjfish
approved these changes
Aug 1, 2019
|
LGTM, thanks! |
bors bot
added a commit
that referenced
this pull request
Aug 1, 2019
590: wasmer-c-api: error visibility changes r=bjfish a=YaronWittenstein I've changed the visibility to `public` in order to support code like here: https://github.com/spacemeshos/svm/blob/52f04b52cc/crates/svm-wasmer-c-api/src/macros.rs#L150 @syrusakbary @bjfish @Hywan Co-authored-by: Yaron Wittenstein <[email protected]> Co-authored-by: Brandon Fish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed the visibility to
publicin order to support code like here:https://github.com/spacemeshos/svm/blob/52f04b52cc/crates/svm-wasmer-c-api/src/macros.rs#L150
@syrusakbary @bjfish @Hywan