Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: wasmer deploy - Improve App Reachability Checks #4847

Closed
theduke opened this issue Jun 14, 2024 · 0 comments · Fixed by #4862
Closed

CLI: wasmer deploy - Improve App Reachability Checks #4847

theduke opened this issue Jun 14, 2024 · 0 comments · Fixed by #4862
Labels
bug Something isn't working edge-cli

Comments

@theduke
Copy link
Contributor

theduke commented Jun 14, 2024

Currently the wasmer deploy command waits for the deployed app version to become reachable.

At the moment it waits until the responses have the expected version header, AND until the responses have a 2xx response code.

This causes long wait times without proper log information if the app is deployed, but doesn't respond with 2xx codes.

We should rewrite the logic to only wait for the header values to match, and log an error if the response is not 2xx.

Also, 3xx headers are valid success responses, so those should also be counted as successful deploys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working edge-cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli/deploy): Check status when waiting for the app to be available wasmerio/wasmer
1 participant
@theduke