Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: "deploy/publish" commands should not ask to bump version if tag already exists #4801

Closed
theduke opened this issue Jun 4, 2024 · 1 comment · Fixed by #4938
Closed
Assignees
Labels

Comments

@theduke
Copy link
Contributor

theduke commented Jun 4, 2024

Currently, when running wasmer deploy with an unchanged named package, the CLI will:

  • build the package locally
  • Upload it if it does not exist in the backend
  • Ask to bump the version ( => tag new version)
  • Deploy

If the package already has a version matching the package hash, the "ask to bump" step should be skipped, and the matching version should be used.

There should potentially be a warning/confirm step if the version number in wasmer.toml does not match the auto-determined version.

@theduke
Copy link
Contributor Author

theduke commented Jun 10, 2024

Relevant backend query:

{
  getPackageVersionByHash ()
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants