Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve redundant BinaryPackage hashing #4785

Closed
theduke opened this issue Jun 3, 2024 — with Linear · 0 comments · Fixed by #4762
Closed

Resolve redundant BinaryPackage hashing #4785

theduke opened this issue Jun 3, 2024 — with Linear · 0 comments · Fixed by #4762
Assignees
@theduke
Labels
performance wasix

Comments

@theduke Linear
Copy link
Contributor

theduke commented Jun 3, 2024

We currently have redundant hashing of the webc in BinaryPackages, which is no longer needed for webc v3s , since the hash is contained in the webc itself.

The redundant hashing step should be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theduke theduke

Labels
performance wasix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(wasix): Remove redundant module hash generation in BinaryPackage wasmerio/wasmer
1 participant
@theduke