Deprecation of cfg_attr(..., crate_type = "...")

[est31]

Hi,

I'm filing this issue to point out that declaring crate_type inside a cfg_attr is deprecated and will error at a certain point in the future. wasmer uses this construct in lib.rs:

wasmer/lib/api/src/lib.rs

Line 29 in f356299

#![cfg_attr(feature = "js", crate_type = "cdylib")]

I would have liked to open a PR to fix the usage but I don't fully understand where everywhere the run instructions are, so instead I opened this issue to discuss approaches to move away from cfg_attr. Thanks!

See also: rust-lang/rust#91632

[linear]

RUN-101 Deprecation of `cfg_attr(..., crate_type = "...")`

[est31]

There is two suggested workarounds in rust-lang/rust#91632 (comment) and rust-lang/rust#91632 (comment)

[xdoardo]

We still need to take care of this.

[est31]

there is a relevant comment from @bjorn3 here rust-lang/rust#129670 (comment)