New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge-CLI: The `wasmer app logs`: panic when no logs present #4417

Closed

theduke opened this issue Jan 29, 2024 · 3 comments

Labels

bug edge-cli priority-high

Contributor

theduke commented Jan 29, 2024 •

edited by barankaraaslan

Loading

It appears the wasmer app logs command can currently run into a situation where retrieving the logs panics.

Reproduction

`wasmer app create -t static-website ...
wasmer app logs XXX

thread 'main' panicked at 'range end index 1000 out of range for slice of length 10', /home/theduke/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wasmer-edge-cli-0.1.4/src/cmd/app/logs.rs:113:25

The text was updated successfully, but these errors were encountered:

theduke added bug priority-high edge-cli labels

linear bot commented Jan 29, 2024

RUN-74 Edge-CLI: The `wasmer app logs`: panic when no logs present

Contributor Author

theduke commented Jan 29, 2024

cc @maminrayej , might this be related to your recent refactoring?

Contributor

maminrayej commented Jan 30, 2024

Do you mean the metrics refactor? I don't think so.
Doesn't this command just send a request to backend? If so, I just added the --watch flag to the code path.
I'll investigate.

maminrayej mentioned this issue

Fetching logs for an app fails #4442

Closed

linear bot mentioned this issue

Fix failure when fetching logs for an app #4449

Closed

maminrayej mentioned this issue

CLI: Fix logic error in indexing in app logs command #4452

Merged

linear bot closed this as not planned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment