Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact Cache: Consider CPU Feature Flags When Loading Artifacts #4188

Closed
theduke opened this issue Aug 28, 2023 · 1 comment · Fixed by #4190
Closed

Artifact Cache: Consider CPU Feature Flags When Loading Artifacts #4188

theduke opened this issue Aug 28, 2023 · 1 comment · Fixed by #4190
Labels
bug Something isn't working 📦 lib-wasi About wasmer-wasi priority-medium Medium priority issue

Comments

@theduke
Copy link
Contributor

theduke commented Aug 28, 2023

Module artifacts are compiled with specific CPU feature flags.

This means artifacts aren't universally compatible, but can only run on CPUs that support all the features the artifact was compiled with.

It is possible to end up with a module cache directory which contains artifacts that are not compatible with the current CPU.
This results in a very confusing errors like missing required CPU features: "EnumSet(AVX512DQ | AVX512VL | AVX512F)"', lib/wasix/tests/runners.rs:75:21 .

The module cache implementation should either check the artifact features for support, or somehow include the cpu features in the cache path. Note: the latter is quite tricky to do in a sensible way that doesn't require lots of cache lookups.

Related to #4187

@theduke
Copy link
Contributor Author

theduke commented Sep 5, 2023

Nothing needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 📦 lib-wasi About wasmer-wasi priority-medium Medium priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants