Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename WasiRuntime #3880

Closed
syrusakbary opened this issue May 18, 2023 · 2 comments · Fixed by #3917
Closed

Rename WasiRuntime #3880

syrusakbary opened this issue May 18, 2023 · 2 comments · Fixed by #3917
Assignees
@Michael-F-Bryan
Labels
🎉 enhancement New feature! priority-high High priority issue
Milestone
v4.0

Comments

@syrusakbary
Copy link
Member

Currently WasiRuntime holds a lot of information on how to run a package.
For example, Runners will take a &impl WasiRuntime in the run_command function (as in PR #3852). But this will make little sense on a EmscriptenRunner.

A simple way to resolve this would be to rename WasiRuntime to RuntimeContext ? (or other names)
@syrusakbary syrusakbary added the 🎉 enhancement New feature! label May 18, 2023
@syrusakbary syrusakbary added this to the v4.0 milestone May 18, 2023
@syrusakbary syrusakbary mentioned this issue May 18, 2023
Merged
@theduke
Copy link
Contributor

theduke commented May 18, 2023

WasiRuntime is fine with me.

@ptitSeb
Copy link
Contributor

ptitSeb commented May 23, 2023

so "Runtime"

@ptitSeb ptitSeb added the priority-high High priority issue label May 23, 2023
@Michael-F-Bryan Michael-F-Bryan mentioned this issue May 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Michael-F-Bryan Michael-F-Bryan

Labels
🎉 enhancement New feature! priority-high High priority issue
Projects
None yet
Milestone
v4.0
Development

Successfully merging a pull request may close this issue.

Rename WasiRuntime to Runtime wasmerio/wasmer
4 participants
@syrusakbary @theduke @ptitSeb @Michael-F-Bryan