Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[breaking change] wasmer_vm should have a VMConfig for configuration #3800

Closed
syrusakbary opened this issue Apr 20, 2023 · 1 comment
Closed

[breaking change] wasmer_vm should have a VMConfig for configuration #3800

syrusakbary opened this issue Apr 20, 2023 · 1 comment
Assignees
@ptitSeb
Labels
priority-high High priority issue
Milestone
v4.0

Comments

@syrusakbary
Copy link
Member

wasmer_vm::catch_traps should receive a VMConfig with a wasm_stack_field: usize on it.
This will imply that some public functions on wasmer_vm will need to change signature and thus, is a breaking change to the public api
@syrusakbary syrusakbary added this to the v4.0 milestone Apr 20, 2023
@syrusakbary syrusakbary mentioned this issue Apr 21, 2023
Closed
@ptitSeb ptitSeb self-assigned this Apr 25, 2023
@ptitSeb ptitSeb mentioned this issue Apr 25, 2023
Closed
@theduke theduke added the priority-high High priority issue label May 9, 2023
@ptitSeb ptitSeb mentioned this issue May 24, 2023
Merged
@syrusakbary
Copy link
Member Author

This is fixed by #3904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptitSeb ptitSeb

Labels
priority-high High priority issue
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
3 participants
@syrusakbary @theduke @ptitSeb