Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI doesn't run unit tests for non-default features #3797

Open
Michael-F-Bryan opened this issue Apr 20, 2023 · 3 comments
Open

CI doesn't run unit tests for non-default features #3797

Michael-F-Bryan opened this issue Apr 20, 2023 · 3 comments
Assignees
Labels
build-system The Wasmer repo's build and CI system priority-medium Medium priority issue
Milestone

Comments

@Michael-F-Bryan
Copy link
Contributor

Describe the bug

It doesn't look like our current CI system runs unit tests for code hidden behind feature flags. That means issues like #3795 can slip in because we don't have full test coverage.

For example, between #3795 and #3739, trying to execute unit tests for the runners in the wasmer-wasix crate (i.e. cargo test --features webc_runner,webc_runner_rt_wasi,webc_runner_rt_wcgi) would fail to build because we'd introduced a !Send+!Sync field to WcgiRunner and the test was passing a WcgiRunner instance to another thread.

@Michael-F-Bryan Michael-F-Bryan added the build-system The Wasmer repo's build and CI system label Apr 20, 2023
@ptitSeb ptitSeb added this to the v4.x milestone Apr 25, 2023
@theduke theduke added priority-medium Medium priority issue priority-low Low priority issue and removed priority-low Low priority issue labels May 9, 2023
Copy link

stale bot commented May 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale Inactive issues or PR label May 9, 2024
@theduke
Copy link
Contributor

theduke commented May 15, 2024

Not stale.

Copy link

stale bot commented Jun 16, 2024

Feel free to reopen the issue if it has been closed by mistake.

@stale stale bot closed this as completed Jun 16, 2024
@theduke theduke reopened this Jun 17, 2024
@stale stale bot removed the 🏚 stale Inactive issues or PR label Jun 17, 2024
@syrusakbary syrusakbary modified the milestones: v4.x, v4.4-pending Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-system The Wasmer repo's build and CI system priority-medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

4 participants