Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a single wasmparser version #3729

Closed
theduke opened this issue Apr 1, 2023 · 1 comment · Fixed by #4426
Closed

Use a single wasmparser version #3729

theduke opened this issue Apr 1, 2023 · 1 comment · Fixed by #4426
Labels
build-system The Wasmer repo's build and CI system dependencies Pull requests that update a dependency file priority-medium Medium priority issue 🔨 refactor Refactor work
Milestone
v4.x

Comments

@theduke
Copy link
Contributor

theduke commented Apr 1, 2023 •
edited
Loading

Right now our various crates have quite a few duplicate dependencies.

-wasix already has a bunch, but the cli is really bad.

There are three different versions of wasmparser in the tree...
@theduke theduke added dependencies Pull requests that update a dependency file build-system The Wasmer repo's build and CI system labels Apr 1, 2023
@ptitSeb
Copy link
Contributor

ptitSeb commented Apr 1, 2023

the wasmparser one is not an easy one. The different version have different API, so it's not a quick win.

@Michael-F-Bryan Michael-F-Bryan added 🔨 refactor Refactor work priority-medium Medium priority issue labels Apr 11, 2023
@Michael-F-Bryan Michael-F-Bryan added this to the v3.x milestone Apr 11, 2023
@ptitSeb ptitSeb modified the milestones: v3.x, v4.x May 3, 2023
@theduke theduke mentioned this issue Jan 31, 2024
Merged
@theduke theduke changed the title Resolve Duplicate Dependencies Use a single wasmparser version Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build-system The Wasmer repo's build and CI system dependencies Pull requests that update a dependency file priority-medium Medium priority issue 🔨 refactor Refactor work
Projects
None yet
Milestone
v4.x
Development

Successfully merging a pull request may close this issue.

deps: Unify wasmparser usage to a single version wasmerio/wasmer
3 participants
@theduke @ptitSeb @Michael-F-Bryan