Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine: Re-add Inherent Methods Moved to NativeEngineExt #3673

Closed
theduke opened this issue Mar 10, 2023 · 1 comment
Closed

Engine: Re-add Inherent Methods Moved to NativeEngineExt #3673

theduke opened this issue Mar 10, 2023 · 1 comment
Labels
🚨 breaking change This Issue or PR involves a breaking change 📦 lib-api About wasmer priority-high High priority issue
Milestone
v3.2

Comments

@theduke
Copy link
Contributor

theduke commented Mar 10, 2023

We moved some architecture specific methods on Engine to NativeEngineExt.

This is a breaking change though, since users now need to import the Ext trait to invoke Engine::new().

To not force a 4.0 release, we will re-introduce inherent methods on Engine, but mark them as deprecated.
@theduke theduke added the 📦 lib-api About wasmer label Mar 10, 2023
@theduke theduke added this to the v3.2 milestone Mar 10, 2023
@ptitSeb ptitSeb added priority-high High priority issue 🚨 breaking change This Issue or PR involves a breaking change labels Mar 14, 2023
@ptitSeb ptitSeb mentioned this issue Mar 22, 2023
Merged
@ptitSeb
Copy link
Contributor

ptitSeb commented Mar 22, 2023

Done

@ptitSeb ptitSeb closed this as completed Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🚨 breaking change This Issue or PR involves a breaking change 📦 lib-api About wasmer priority-high High priority issue
Projects
None yet
Milestone
v3.2
Development

No branches or pull requests
2 participants
@theduke @ptitSeb