Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fd_mmap Memory Implementation #3608

Closed
theduke opened this issue Feb 22, 2023 · 2 comments
Closed

Test fd_mmap Memory Implementation #3608

theduke opened this issue Feb 22, 2023 · 2 comments
Labels
🎉 enhancement New feature! priority-medium Medium priority issue 🏚 stale Inactive issues or PR 🧪 tests I love tests
Milestone

Comments

@theduke
Copy link
Contributor

theduke commented Feb 22, 2023

#3422 added a fd_mmap memory implementation that is located in the wasmer-sys-utils crate.

This implementation has active users, but currently only a commented out test. (in lib/sys-utils/tests).

The test should be re-enabled, and the memory implementation should get extensive test coverage.

@theduke theduke added 🎉 enhancement New feature! 🧪 tests I love tests labels Feb 22, 2023
This was referenced Feb 22, 2023
@ptitSeb ptitSeb added the priority-medium Medium priority issue label Feb 28, 2023
@ptitSeb ptitSeb added this to the v3.3 milestone Feb 28, 2023
@ptitSeb ptitSeb modified the milestones: v3.3, v4.x Apr 20, 2023
Copy link

stale bot commented Apr 21, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale Inactive issues or PR label Apr 21, 2024
Copy link

stale bot commented May 22, 2024

Feel free to reopen the issue if it has been closed by mistake.

@stale stale bot closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 enhancement New feature! priority-medium Medium priority issue 🏚 stale Inactive issues or PR 🧪 tests I love tests
Projects
None yet
Development

No branches or pull requests

2 participants