Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Valgrind on CI to Detect Memory Leaks #3533

Closed
theduke opened this issue Jan 25, 2023 · 2 comments
Closed

Run Valgrind on CI to Detect Memory Leaks #3533

theduke opened this issue Jan 25, 2023 · 2 comments
Assignees
@ptitSeb
Labels
build-system The Wasmer repo's build and CI system 🎉 enhancement New feature! memory-leak priority-low Low priority issue 🏚 stale Inactive issues or PR

Comments

@theduke
Copy link
Contributor

theduke commented Jan 25, 2023 •
edited
Loading

To prevent a situation like #3485 from re-occurring we should include a Valgrind job on CI that runs a bunch of tests in a typical usage scenario, and fails in case of leaks.

We do have oss-fuzz integration now, but we should still detect these things early on in our own tooling.
@theduke theduke added 🎉 enhancement New feature! memory-leak build-system The Wasmer repo's build and CI system labels Jan 25, 2023
@ptitSeb ptitSeb added the priority-low Low priority issue label Jan 31, 2023
@ptitSeb ptitSeb self-assigned this Jan 31, 2023
@stale Stale
Copy link

stale bot commented Feb 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale Inactive issues or PR label Feb 2, 2024
@stale Stale
Copy link

stale bot commented Mar 3, 2024

Feel free to reopen the issue if it has been closed by mistake.

@stale stale bot closed this as completed Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptitSeb ptitSeb

Labels
build-system The Wasmer repo's build and CI system 🎉 enhancement New feature! memory-leak priority-low Low priority issue 🏚 stale Inactive issues or PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theduke @ptitSeb