Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out why adding an Option<Pages> to SerializableModule made compiled binaries fail #3497

Closed
fschutt opened this issue Jan 18, 2023 · 1 comment
Closed

Figure out why adding an Option<Pages> to SerializableModule made compiled binaries fail #3497

fschutt opened this issue Jan 18, 2023 · 1 comment

Comments

@fschutt
Copy link
Contributor

fschutt commented Jan 18, 2023

Follow-up for #3496: We need to figure out why this PR fixes the CI failure of binaries compiled with --object-format serialized. My personal guess is that because we use Option<>, the binary format isn't stable (in difference to rkyv::ArchivedOption, which has a #[repr(u8)] tag).
@syrusakbary syrusakbary mentioned this issue Jan 24, 2023
Closed
@ptitSeb
Copy link
Contributor

ptitSeb commented Jan 24, 2023

Actual root cause tracked on #3529, closing this one.

@ptitSeb ptitSeb closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ptitSeb @fschutt