Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Compiled Module Artifact Reusability Crashes #3484

Closed
theduke opened this issue Jan 17, 2023 · 1 comment
Closed

Investigate Compiled Module Artifact Reusability Crashes #3484

theduke opened this issue Jan 17, 2023 · 1 comment
Assignees
@theduke
Labels
🕵️ needs investigation The issue/PR needs further investigation priority-high High priority issue
Milestone
v3.2

Comments

@theduke
Copy link
Contributor

theduke commented Jan 17, 2023

In Deploy we are encountering crashes (SEGFAULTs) when loading compiled artifacts after updating the wasmer-wasi crate, even though no changes were made to the code.

We need to:

  • Investigate why and how this happens
  • Add validation to ensure invalid artifacts produce an error instead of crashes

Steps to reproduce

Todo @theduke : find a simple way to reproduce
@ptitSeb ptitSeb added the 🕵️ needs investigation The issue/PR needs further investigation label Jan 17, 2023
@ptitSeb ptitSeb added this to the v3.2 milestone Jan 17, 2023
@ptitSeb ptitSeb added the priority-high High priority issue label Jan 17, 2023
@Michael-F-Bryan
Copy link
Contributor

This should have been fixed by #3693.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theduke theduke

Labels
🕵️ needs investigation The issue/PR needs further investigation priority-high High priority issue
Projects
None yet
Milestone
v3.2
Development

No branches or pull requests
3 participants
@theduke @ptitSeb @Michael-F-Bryan