You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently create-obj just creates a static_defs.h and a wasm.h file in the current directory whereas create-exe consumes this file. These tests are reliant on the current directory, so they break very easily if you run them from any other directory.
... because the static_defs.h is being generated, but not included in the create-exe. We need to find a way to make the interaction between static_defs.h and wasm.h as smooth as possible and also ideally not generate them in the current directory (since that might not be what the user wants). Also, we need to make tests more reliable by never assuming relative file paths, always canonicalize them and never rely on the current directory being stable (no ./blah.h)
For example, this file path needs to be fixed to be configurable:
Currently
create-obj
just creates astatic_defs.h
and awasm.h
file in the current directory whereascreate-exe
consumes this file. These tests are reliant on the current directory, so they break very easily if you run them from any other directory.Currently this test will fail:
... because the
static_defs.h
is being generated, but not included in thecreate-exe
. We need to find a way to make the interaction betweenstatic_defs.h
andwasm.h
as smooth as possible and also ideally not generate them in the current directory (since that might not be what the user wants). Also, we need to make tests more reliable by never assuming relative file paths, always canonicalize them and never rely on the current directory being stable (no./blah.h
)For example, this file path needs to be fixed to be configurable:
wasmer/lib/cli/src/commands/create_exe.rs
Line 241 in 118b49e
... so that we can have an interaction between
create-obj
generating thatstatic-defs.h
file andcreate-exe
consuming it.The text was updated successfully, but these errors were encountered: