Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Failure due to missing sub module 'wit-bindgen' in 'wasmer/lib/wasi-types/' #3278

Closed
canewsin opened this issue Nov 4, 2022 · 5 comments
Labels
bug Something isn't working priority-medium Medium priority issue
Milestone

Comments

@canewsin
Copy link

canewsin commented Nov 4, 2022

Describe the bug

Using witbindgen dep via git url
Security Audit failing because of missing above submodule

https://github.com/canewsin/zeronet-rs/actions/runs/3393271427/jobs/5640413699

https://github.com/wasmerio/wasmer/tree/master/lib/wasi-types

@canewsin canewsin added the bug Something isn't working label Nov 4, 2022
@canewsin
Copy link
Author

canewsin commented Nov 7, 2022

@syrusakbary

@fschutt
Copy link
Contributor

fschutt commented Nov 8, 2022

We renamed wit-bindgen to wai-bindgen to distinguish it from the bytecodealliance version. That is probably why it's failing because there is no wit-bindgen-wasmer crate anymore.

Instead of depending on GitHub, you can depend on crates.io: https://crates.io/crates/wai-bindgen-wasmer

@fschutt
Copy link
Contributor

fschutt commented Nov 8, 2022

Internally, we should update all references from wit-bindgen to wai-bindgen, cc @syrusakbary

@fschutt fschutt added this to the v3.0 milestone Nov 8, 2022
@fschutt fschutt added the priority-medium Medium priority issue label Nov 8, 2022
@fschutt
Copy link
Contributor

fschutt commented Dec 6, 2022

Related to #3387

@fschutt fschutt modified the milestones: v3.0, v3.2 Dec 6, 2022
@Michael-F-Bryan
Copy link
Contributor

This should have been resolved when we used the wai-bindgen-xxx crates from crates.io instead of a git submodule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

3 participants