Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for using cargo-binstall to install wasmer #3106

Closed
NobodyXu opened this issue Aug 13, 2022 · 2 comments · Fixed by #3176
Closed

Support for using cargo-binstall to install wasmer #3106

NobodyXu opened this issue Aug 13, 2022 · 2 comments · Fixed by #3176
Labels
🎉 enhancement New feature! priority-low Low priority issue
Milestone

Comments

@NobodyXu
Copy link
Contributor

cargo-binstall provides a simple way to install prebuilt rust binaries.

Supporting it is not that hard consider that wasmer already put prebuilt binaries onto its release page.

The limitation to cargo-binstall is that it cannot install WASMER_DIR, so either we can propose a new feature to cargo-binstall or wasmer can support downloading WASMER_DIR required for wasmer create-exe.

@NobodyXu NobodyXu added the 🎉 enhancement New feature! label Aug 13, 2022
@epilys epilys added this to the v3.x milestone Aug 16, 2022
@epilys epilys self-assigned this Aug 16, 2022
@epilys epilys added the priority-low Low priority issue label Aug 16, 2022
@NobodyXu
Copy link
Contributor Author

@epilys If the WASMER_DIR part is doable, then can we also add support for cargo-binstall?

It's also quite easy.

@epilys epilys removed their assignment Aug 24, 2022
@NobodyXu
Copy link
Contributor Author

NobodyXu commented Sep 7, 2022

I might submit a PR for this today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 enhancement New feature! priority-low Low priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants