Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Wasmer-WASI types with wit-bindgen bindings #2972

Closed
syrusakbary opened this issue Jun 24, 2022 · 4 comments · Fixed by #3177
Closed

Update Wasmer-WASI types with wit-bindgen bindings #2972

syrusakbary opened this issue Jun 24, 2022 · 4 comments · Fixed by #3177
Assignees
Labels
priority-low Low priority issue
Milestone

Comments

@syrusakbary
Copy link
Member

syrusakbary commented Jun 24, 2022

Once #2911 is done, we should update Wasmer-WASI with those bindings

@syrusakbary syrusakbary added the priority-low Low priority issue label Jul 5, 2022
@syrusakbary syrusakbary added this to the v3.0 milestone Jul 5, 2022
@syrusakbary
Copy link
Member Author

This implies removing the wasi-types crate and using the autogenerated types from wit-bindgen

https://github.com/wasmerio/wasmer/tree/master/lib/wasi-types/src

@syrusakbary
Copy link
Member Author

Here's the old witx format, that we may need to update to newest format:
https://github.com/WebAssembly/WASI/tree/main/phases/old/snapshot_0/witx

Note that WITX has splitted into different proposals, and most of the functions preserve the same signature:

@syrusakbary
Copy link
Member Author

It might be good to double check the types with: https://github.com/sunfishcode/preview1.wasm/tree/main/wit

@syrusakbary
Copy link
Member Author

This issue should be fixed by #3177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-low Low priority issue
Projects
None yet
3 participants