Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mismatch with Wasm C API on wasm_extern_as_* functions return value #2197

Closed
MarkMcCaskey opened this issue Mar 18, 2021 · 0 comments · Fixed by #2208
Closed

Mismatch with Wasm C API on wasm_extern_as_* functions return value #2197

MarkMcCaskey opened this issue Mar 18, 2021 · 0 comments · Fixed by #2208
Labels
bug Something isn't working 📦 lib-c-api About wasmer-c-api

Comments

@MarkMcCaskey
Copy link
Contributor

Found while making #2196, the wasm_extern_as_* functions do not return owned values. They should be like casts, not allocating new data that needs to be freed. This change is best done by refactoring what wasm_extern_t looks like on the Rust side, in my opinion. It shouldn't be too hard but it is a breaking change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working 📦 lib-c-api About wasmer-c-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement to/from casting for extern w/ no allocation wasmerio/wasmer
1 participant
@MarkMcCaskey