Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wasi_polloneoff on Windows #2034

Closed
MarkMcCaskey opened this issue Jan 21, 2021 · 4 comments
Closed

Fix wasi_polloneoff on Windows #2034

MarkMcCaskey opened this issue Jan 21, 2021 · 4 comments
Labels
🎉 enhancement New feature! 📦 lib-wasi About wasmer-wasi 🖼️ platform-windows This issue happens on Windows priority-medium Medium priority issue

Comments

@MarkMcCaskey
Copy link
Contributor

We're missing wasi_polloneoff on Windows. It's a bit tricky, but maybe we can get it working well enough to run applications that need to sleep.

See also #1971, #570

@MarkMcCaskey MarkMcCaskey added 🎉 enhancement New feature! 📦 lib-wasi About wasmer-wasi labels Jan 21, 2021
@nlewycky
Copy link
Contributor

Is there a spec document for this function?

@Hywan
Copy link
Contributor

Hywan commented Jan 26, 2021

The only reference to wasi_polloneoff that Google or Ecosia or other search engines found is… this issue :-D.

Maybe this https://github.com/WebAssembly/WASI/blob/96c202b046e28d215c64d3a558566141d8efd8b9/phases/ephemeral/witx/wasi_ephemeral_poll.witx?

@MarkMcCaskey
Copy link
Contributor Author

Is there a spec document for this function?

In general, no. There's https://github.com/WebAssembly/WASI/blob/main/phases/snapshot/docs.md#poll_oneoff which is a description of the function and its parameters but it doesn't get into much real detail.

If you care about being precise, you can read the WASI libc code but that's not particularly easy. Most of our WASI calls have been developed by reading the docs I linked above and working with Wasm modules that use that syscall until they appear to behave correctly.

There's on-going talks about creating standardized spec tests for WASI though, so I think that'll go a long way towards improving consistency in implementations

@Hywan Hywan added the 🖼️ platform-windows This issue happens on Windows label Jul 16, 2021
@syrusakbary
Copy link
Member

Closing this in favor of #570

@syrusakbary syrusakbary added the priority-medium Medium priority issue label Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 enhancement New feature! 📦 lib-wasi About wasmer-wasi 🖼️ platform-windows This issue happens on Windows priority-medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

4 participants