Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmer-c-api's documentation is broken on docs.rs #1954

Closed
Hywan opened this issue Dec 18, 2020 · 1 comment · Fixed by #2044
Closed

wasmer-c-api's documentation is broken on docs.rs #1954

Hywan opened this issue Dec 18, 2020 · 1 comment · Fixed by #2044
Assignees
Labels
bug Something isn't working 📦 lib-c-api About wasmer-c-api

Comments

@Hywan
Copy link
Contributor

Hywan commented Dec 18, 2020

The wasmer-c-api's documentation can not be generated on docs.rs because of this:

https://docs.rs/crate/wasmer-c-api/1.0.0-beta2/builds/325937

[INFO] [stderr] error: failed to run custom build command for `wasmer-c-api v1.0.0-beta2 (/opt/rustwide/workdir)`
[INFO] [stderr] 
[INFO] [stderr] Caused by:
[INFO] [stderr]   process didn't exit successfully: `/opt/rustwide/target/debug/build/wasmer-c-api-e213afef7dae2643/build-script-build` (exit code: 101)
[INFO] [stderr]   --- stderr
[INFO] [stderr]   thread 'main' panicked at 'Unable to copy the generated C bindings: Os { code: 30, kind: Other, message: "Read-only file system" }', build.rs:124:14
[INFO] [stderr]   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

It would be great to see how we could solve this.

@Hywan Hywan added bug Something isn't working 📦 lib-c-api About wasmer-c-api labels Dec 18, 2020
@MarkMcCaskey
Copy link
Contributor

This has been a long running issue for as long as we've generated header files with build.rs I believe...

Maybe we can do a diff in build.rs before ever writing to the file system? That should at least fix it in this case. Alternatively, we may want to avoid writing outside of the TARGET/BUILD directory at all in build.rs (it also breaks cargo publish...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 📦 lib-c-api About wasmer-c-api
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants