Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Wasm C API implementation #1860

Closed
MarkMcCaskey opened this issue Dec 2, 2020 · 4 comments · Fixed by #2973
Closed

Simplify Wasm C API implementation #1860

MarkMcCaskey opened this issue Dec 2, 2020 · 4 comments · Fixed by #2973
Labels
🎉 enhancement New feature! 📦 lib-c-api About wasmer-c-api 🕵️ needs investigation The issue/PR needs further investigation priority-medium Medium priority issue
Milestone
v3.0

Comments

@MarkMcCaskey
Copy link
Contributor

As the Wasmer Rust API’s ownership becomes more like the C API, we can start simplifying some of the code in our C API implementation. For example currently we pass around lots of Arc<Instance> in order to keep things like functions working after the instance has been dropped at the C API level. With the recent changes, that kind of explicit thing at the C API level shouldn’t be necessary anymore
@MarkMcCaskey MarkMcCaskey added 🎉 enhancement New feature! 📦 lib-c-api About wasmer-c-api labels Dec 2, 2020
@Amanieu Amanieu added the priority-medium Medium priority issue label Oct 20, 2021
@epilys epilys added this to the v3.0 milestone Apr 27, 2022
@syrusakbary
Copy link
Member

C-API is based on https://github.com/WebAssembly/wasm-c-api so we should respect that while changing the internals

@syrusakbary syrusakbary added the 🕵️ needs investigation The issue/PR needs further investigation label Jun 1, 2022
@syrusakbary
Copy link
Member

We might need to merge Context and Store together to be able to not do any breaking change on the official Wasm C API

@syrusakbary
Copy link
Member

This is fixed by #2973

@epilys epilys linked a pull request Jun 29, 2022 that will close this issue
Port C API to new Context API #2973
Merged
@epilys epilys reopened this Jun 29, 2022
@syrusakbary
Copy link
Member

This was refactored and fixed in #3013. Closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎉 enhancement New feature! 📦 lib-c-api About wasmer-c-api 🕵️ needs investigation The issue/PR needs further investigation priority-medium Medium priority issue
Projects
None yet
Milestone
v3.0
Development

Successfully merging a pull request may close this issue.

Port C API to new Context API wasmerio/wasmer
4 participants
@syrusakbary @Amanieu @MarkMcCaskey @epilys