Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctx::memory missing in compatibility wrapper #1535

Closed
webmaster128 opened this issue Aug 5, 2020 · 4 comments
Closed

Ctx::memory missing in compatibility wrapper #1535

webmaster128 opened this issue Aug 5, 2020 · 4 comments
Assignees
Labels
1.0 Wasmer at 1.0

Comments

@webmaster128
Copy link
Contributor

I'm migrating a project using the compatibility wrapper lib/deprecated/runtime-core, which turns out to be very very helpful for the migration.

I'm missing a function vm::Ctx::memory (https://github.com/wasmerio/wasmer/blob/0.17.1/lib/runtime-core/src/vm.rs#L392-L405). Can this easily be added or is there a different way to get memory(0) given a context?

@syrusakbary syrusakbary transferred this issue from another repository Aug 14, 2020
@webmaster128
Copy link
Contributor Author

Is there a chance this can be implemented? For us this could be a major step in the migration to Wasmer Reborn as it would make the codebase compile via wasmer/lib/deprecated/runtime-core. From there we can gradually refactor out runtime-core.

@Hywan
Copy link
Contributor

Hywan commented Sep 22, 2020

Hello @webmaster128,

Unfortunately it's not that easy to port the vm::Ctx::memory as is. I'll try to see if I can find a nice workaround for it. If you don't have any reply from me in a couple of days, feel free to ping me again!

@webmaster128
Copy link
Contributor Author

Hi @Hywan, initially the compatibility wrapper seemed like a great way to gradually upgrade code until I hit this. In the meantime I gave up using the compatibility wrapper and moved towards to new API. It is not yet fully compiling but we are getting there. So I don't need this feature anymore. Maybe others do, I don't know. Feel free to close it if you think this type of use case is too hard to support.

@Hywan
Copy link
Contributor

Hywan commented Sep 22, 2020

Thanks @webmaster128 :-).

Yes migrating is not super difficult depending of your project. The compatibility layer is here for casual usages of Wasmer, mostly. I'm going to close that issue for the moment.

If someone else needs this feature, please raise your hand, and I'll be super happy to help and to implement that missing feature!

@Hywan Hywan closed this as completed Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 Wasmer at 1.0
Projects
None yet
Development

No branches or pull requests

3 participants