Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dynasm-rs 1.0 to enable singlepass backend to be compilable on stable Rust 1.45+ #1488

Closed
frol opened this issue Jul 1, 2020 · 4 comments
Labels
🎉 enhancement New feature!

Comments

@frol
Copy link

frol commented Jul 1, 2020

Motivation

Compilation on stable Rust release is a major step forward to general stability.

Proposed solution

Rust 1.45 will stabilize some nightly features that were required for dynasm-rs and with the efforts towards compilation on stable Rust release from dynasm-rs team (CensoredUsername/dynasm-rs#31), dynasm-rs 0.7 is ready to be compilable on stable Rust 1.45. It seems that dynasm-rs is the major if not the only piece requiring nightly Rust features, so with Rust 1.45 and dynasm-rs 0.7 it should be possible to have wasmer singlepass backend to be compilable on stable Rust.

@repi
Copy link
Contributor

repi commented Jul 1, 2020

We just ran into this as well, would be great to upgrade to 0.7 and not require nightly

@webmaster128
Copy link
Contributor

This would be a massive improvement for our development flow as well!

@frol frol changed the title Use dynasm-rs 0.7+ to enable singlepass backend to be compilable on stable Rust 1.45+ Use dynasm-rs 1.0 to enable singlepass backend to be compilable on stable Rust 1.45+ Jul 20, 2020
@frol
Copy link
Author

frol commented Jul 20, 2020

dynasm-rs 1.0 is released targeting stable Rust 1.45+ CensoredUsername/dynasm-rs#31 🎉

@MarkMcCaskey
Copy link
Contributor

This should now work with the Wasmer refactor on master and singlepass published at https://crates.io/crates/wasmer-compiler-singlepass !

Unfortunately we don't have docs to aid in the transition between the old wasmer and the new wasmer yet, but stay tuned to #1553 for news on their development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 enhancement New feature!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants