Skip to content

Commit

Permalink
Remove vestigial debug features from various crates
Browse files Browse the repository at this point in the history
  • Loading branch information
Mark McCaskey committed Jan 14, 2020
1 parent 12f7416 commit c03f2f1
Show file tree
Hide file tree
Showing 9 changed files with 5 additions and 16 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## **[Unreleased]**

- [#1147](https://github.com/wasmerio/wasmer/pull/1147) Remove `log` and `trace` macros from `wasmer-runtime-core`, remove `debug` and `trace` features from `wasmer-*` crates, use the `log` crate for logging and use `fern` in the Wasmer CLI binary to output log messages. To disable colorized output, set the `WASMER_DISABLE_COLOR` environment variable.
- [#1128](https://github.com/wasmerio/wasmer/pull/1128) Fix a crash when a host function is missing and the `allow_missing_functions` flag is enabled
- [#1099](https://github.com/wasmerio/wasmer/pull/1099) Remove `backend::Backend` from `wasmer_runtime_core`
- [#1097](https://github.com/wasmerio/wasmer/pull/1097) Move inline breakpoint outside of runtime backend
Expand Down
5 changes: 2 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,9 @@ typetag = "0.1" # used by the plugin example
[features]
default = ["fast-tests", "wasi", "backend-cranelift"]
"loader-kernel" = ["wasmer-kernel-loader"]
debug = ["wasmer-runtime-core/debug", "fern", "log/max_level_debug", "log/release_max_level_debug"]
trace = ["wasmer-runtime-core/trace", "log/max_level_trace", "log/release_max_level_trace"]
debug = ["fern", "log/max_level_debug", "log/release_max_level_debug"]
trace = ["fern", "log/max_level_trace", "log/release_max_level_trace"]
docs = ["wasmer-runtime/docs"]
extra-debug = ["wasmer-clif-backend/debug", "wasmer-runtime-core/debug"]
# This feature will allow cargo test to run much faster
fast-tests = []
backend-cranelift = [
Expand Down
5 changes: 1 addition & 4 deletions lib/clif-backend/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,4 @@ version = "0.0.7"

[target.'cfg(windows)'.dependencies]
winapi = { version = "0.3", features = ["errhandlingapi", "minwindef", "minwinbase", "winnt"] }
wasmer-win-exception-handler = { path = "../win-exception-handler", version = "0.12.0" }

[features]
debug = ["wasmer-runtime-core/debug"]
wasmer-win-exception-handler = { path = "../win-exception-handler", version = "0.12.0" }
3 changes: 0 additions & 3 deletions lib/emscripten/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,3 @@ wasmer-runtime-core = { path = "../runtime-core", version = "0.12.0" }

[target.'cfg(windows)'.dependencies]
getrandom = "0.1"

[features]
debug = ["wasmer-runtime-core/debug"]
1 change: 0 additions & 1 deletion lib/llvm-backend/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,4 @@ rustc_version = "0.2"
wabt = "0.9.1"

[features]
debug = ["wasmer-runtime-core/debug"]
test = []
1 change: 0 additions & 1 deletion lib/runtime-c-api/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ optional = true

[features]
default = ["cranelift-backend", "wasi"]
debug = ["wasmer-runtime/debug"]
singlepass-backend = ["wasmer-runtime/singlepass", "wasmer-runtime/default-backend-singlepass"]
cranelift-backend = ["wasmer-runtime/cranelift", "wasmer-runtime/default-backend-cranelift"]
llvm-backend = ["wasmer-runtime/llvm", "wasmer-runtime/default-backend-llvm"]
Expand Down
2 changes: 0 additions & 2 deletions lib/runtime-core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,5 @@ rustc_version = "0.2"
cc = "1.0"

[features]
debug = []
trace = ["debug"]
managed = []
deterministic-execution = ["wasmparser/deterministic"]
1 change: 0 additions & 1 deletion lib/runtime/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ default = ["cranelift", "default-backend-cranelift"]
docs = []
cranelift = ["wasmer-clif-backend"]
cache = ["cranelift"]
debug = ["wasmer-clif-backend/debug", "wasmer-runtime-core/debug"]
llvm = ["wasmer-llvm-backend"]
singlepass = ["wasmer-singlepass-backend"]
default-backend-singlepass = ["singlepass"]
Expand Down
2 changes: 1 addition & 1 deletion src/bin/wasmer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -984,7 +984,7 @@ fn get_backend(backend: Backend, path: &PathBuf) -> Backend {

fn run(options: &mut Run) {
options.backend = get_backend(options.backend, &options.path);
#[cfg(feature = "debug")]
#[cfg(any(feature = "debug", feature = "trace"))]
{
if options.debug {
logging::set_up_logging().expect("failed to set up logging");
Expand Down

0 comments on commit c03f2f1

Please sign in to comment.