From 2335a82a2eb6cbdd5dfa6b87a5952d26a7f7d2be Mon Sep 17 00:00:00 2001
From: Christoph Herzog <chris@theduke.at>
Date: Thu, 8 Aug 2024 13:12:17 +0200
Subject: [PATCH] Partial fix for mio net refactor

---
 lib/virtual-net/src/host.rs | 67 +++++++++++++++++++++++++++++++------
 1 file changed, 56 insertions(+), 11 deletions(-)

diff --git a/lib/virtual-net/src/host.rs b/lib/virtual-net/src/host.rs
index 0d14a1e2675..de9ca4dbca1 100644
--- a/lib/virtual-net/src/host.rs
+++ b/lib/virtual-net/src/host.rs
@@ -16,6 +16,9 @@ use std::net::{IpAddr, Ipv4Addr, Ipv6Addr, Shutdown, SocketAddr};
 use std::os::fd::AsRawFd;
 #[cfg(not(target_os = "windows"))]
 use std::os::fd::RawFd;
+#[cfg(windows)]
+use std::os::windows::io::AsRawSocket;
+
 use std::sync::Arc;
 use std::task::Poll;
 use std::time::Duration;
@@ -87,7 +90,21 @@ impl VirtualNetworking for LocalNetworking {
         _reuse_addr: bool,
     ) -> Result<Box<dyn VirtualUdpSocket + Sync>> {
         let socket = mio::net::UdpSocket::bind(addr).map_err(io_err_into_net_error)?;
-        socket2::SockRef::from(&socket).set_nonblocking(true).ok();
+
+        {
+            #[cfg(not(windows))]
+            let sockref = socket2::SockRef::from(&socket);
+            #[cfg(windows)]
+            let sockref = unsafe {
+                socket2::SockRef::from(&std::os::windows::io::BorrowedSocket::borrow_raw(
+                    socket.stream.as_raw_socket(),
+                ))
+                .set_nonblocking(true)
+                .ok();
+            };
+
+            sockref.set_nonblocking(true).ok();
+        }
 
         #[allow(unused_mut)]
         let mut ret = LocalUdpSocket {
@@ -118,6 +135,7 @@ impl VirtualNetworking for LocalNetworking {
         mut peer: SocketAddr,
     ) -> Result<Box<dyn VirtualTcpSocket + Sync>> {
         let stream = mio::net::TcpStream::connect(peer).map_err(io_err_into_net_error)?;
+
         socket2::SockRef::from(&stream).set_nonblocking(true).ok();
         if let Ok(p) = stream.peer_addr() {
             peer = p;
@@ -333,6 +351,20 @@ impl LocalTcpStream {
 
         ret
     }
+
+    fn sock_ref<'a>(&'a self) -> socket2::SockRef<'a> {
+        #[cfg(not(windows))]
+        let r = socket2::SockRef::from(&self.stream);
+
+        #[cfg(windows)]
+        let r = unsafe {
+            socket2::SockRef::from(&std::os::windows::io::BorrowedSocket::borrow_raw(
+                self.stream.as_raw_socket(),
+            ))
+        };
+
+        r
+    }
 }
 
 impl VirtualTcpSocket for LocalTcpStream {
@@ -363,16 +395,14 @@ impl VirtualTcpSocket for LocalTcpStream {
     }
 
     fn set_keepalive(&mut self, keepalive: bool) -> Result<()> {
-        socket2::SockRef::from(&self.stream)
+        self.sock_ref()
             .set_keepalive(true)
             .map_err(io_err_into_net_error)?;
         Ok(())
     }
 
     fn keepalive(&self) -> Result<bool> {
-        let ret = socket2::SockRef::from(&self.stream)
-            .keepalive()
-            .map_err(io_err_into_net_error)?;
+        let ret = self.sock_ref().keepalive().map_err(io_err_into_net_error)?;
         Ok(ret)
     }
 
@@ -444,16 +474,15 @@ impl VirtualTcpSocket for LocalTcpStream {
 
 impl VirtualConnectedSocket for LocalTcpStream {
     fn set_linger(&mut self, linger: Option<Duration>) -> Result<()> {
-        socket2::SockRef::from(&self.stream)
+        self.sock_ref()
             .set_linger(linger)
             .map_err(io_err_into_net_error)?;
         Ok(())
     }
 
     fn linger(&self) -> Result<Option<Duration>> {
-        socket2::SockRef::from(&self.stream)
-            .linger()
-            .map_err(io_err_into_net_error)
+        let sockref = self.sock_ref();
+        sockref.linger().map_err(io_err_into_net_error)
     }
 
     fn try_send(&mut self, data: &[u8]) -> Result<usize> {
@@ -654,6 +683,22 @@ pub struct LocalUdpSocket {
     backlog: VecDeque<(BytesMut, SocketAddr)>,
 }
 
+impl LocalUdpSocket {
+    fn sock_ref<'a>(&'a self) -> socket2::SockRef<'a> {
+        #[cfg(not(windows))]
+        let r = socket2::SockRef::from(&self.socket);
+
+        #[cfg(windows)]
+        let r = unsafe {
+            socket2::SockRef::from(&std::os::windows::io::BorrowedSocket::borrow_raw(
+                self.stream.as_raw_socket(),
+            ))
+        };
+
+        r
+    }
+}
+
 impl VirtualUdpSocket for LocalUdpSocket {
     fn set_broadcast(&mut self, broadcast: bool) -> Result<()> {
         self.socket
@@ -702,13 +747,13 @@ impl VirtualUdpSocket for LocalUdpSocket {
     }
 
     fn join_multicast_v4(&mut self, multiaddr: Ipv4Addr, iface: Ipv4Addr) -> Result<()> {
-        socket2::SockRef::from(&self.socket)
+        self.sock_ref()
             .join_multicast_v4(&multiaddr, &iface)
             .map_err(io_err_into_net_error)
     }
 
     fn leave_multicast_v4(&mut self, multiaddr: Ipv4Addr, iface: Ipv4Addr) -> Result<()> {
-        socket2::SockRef::from(&self.socket)
+        self.sock_ref()
             .leave_multicast_v4(&multiaddr, &iface)
             .map_err(io_err_into_net_error)
     }