Skip to content
This repository was archived by the owner on Jun 14, 2023. It is now read-only.

Context on wapm-cli features #287

Open
syrusakbary opened this issue Oct 18, 2022 · 1 comment
Open

Context on wapm-cli features #287

syrusakbary opened this issue Oct 18, 2022 · 1 comment
Assignees

Comments

@syrusakbary
Copy link
Member

syrusakbary commented Oct 18, 2022

Current wapm-cli features:

[features]
default = ["full","packagesigning", "sqlite-bundled"]
sqlite-bundled = ["rusqlite/bundled"]
telemetry = ["sentry"]
update-notifications= ["billboard", "colored"]
prehash-module = ["hex", "blake3"]
packagesigning = []#[cfg(feature = "full")]
integration_tests = ["maplit", "wapm-toml/integration_tests"]
full = [ "dirs", "rusqlite", "prettytable-rs", "reqwest" ]

Analysis on code feature flags:
sqlite-bundled: it helped on using sqlite in macOS M1 (see #201)
telemetry: to add sentry monitoring
update-notifications: to check on the background when wasmer has a new version (this can be probably removed / always on or based on config)
prehash-module: it can probably be removed since it doesn't add that much value and can be always included (doesn't add that much code size)
packagesigning: it can probably be removed and be always on
integration_tests: it should be removed.

This leaves the only following feature flags:

  • sqlite-bundled: since it's to solve a macOS M1 issue when using sqlite
  • telemetry: we need to think if we want this to be always on or based on config instead
@Michael-F-Bryan
Copy link
Contributor

After talking with @syrusakbary and @fschutt, we're thinking we won't immediately update feature flags now. Instead, we'll try to removing things while migrating wapm's functionality into the wasmer CLI.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants