Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use esbuild #25

Closed
princejoogie opened this issue Nov 4, 2021 · 5 comments · Fixed by #39
Closed

use esbuild #25

princejoogie opened this issue Nov 4, 2021 · 5 comments · Fixed by #39
Assignees
@princejoogie
Labels
chore Issue/Pull Request Label for Housekeeping tweak Issue/Pull Request for Tweaks
Milestone
v1.0.0 Beta 🌱

Comments

@princejoogie
Copy link
Contributor

both parcel and esbuild dont do typechecking, this has been a discussion in the community.

do we stick with this?

  • implement esbuild
  • let your IDE be responsible for typechecking in development stage
  • will add typechecking on yarn build
@warengonzaga warengonzaga added in review Issue/Pull Request Label for In Review Status suggestion Issue/Discussions Label for Suggestions labels Nov 4, 2021
@warengonzaga
Copy link
Owner

Hi, @princejoogie is this already added?

@warengonzaga warengonzaga added the waiting response Issue/Pull Request Label for Waiting Response label Nov 16, 2021
@warengonzaga
Copy link
Owner

Any updates on this? @princejoogie I guess we already solved this?

@princejoogie
Copy link
Contributor Author

Any updates on this? @princejoogie I guess we already solved this?

searching more on the parcel docs, I found an experimental type-checking feature of parcel. we can opt to set this up.
https://parceljs.org/languages/typescript/#type-checking

@warengonzaga
Copy link
Owner

Any updates on this? @princejoogie I guess we already solved this?

searching more on the parcel docs, I found an experimental type-checking feature of parcel. we can opt to set this up. https://parceljs.org/languages/typescript/#type-checking

Awesome, let's try it and submit a PR.

@warengonzaga warengonzaga added in progress Issue/Pull Request Label for In Progress Status tweak Issue/Pull Request for Tweaks and removed in review Issue/Pull Request Label for In Review Status waiting response Issue/Pull Request Label for Waiting Response suggestion Issue/Discussions Label for Suggestions labels Dec 8, 2021
@warengonzaga warengonzaga added this to the v1.0.0 Beta 🌱 milestone Dec 8, 2021
@princejoogie princejoogie mentioned this issue Dec 9, 2021
Merged
@warengonzaga warengonzaga linked a pull request Dec 9, 2021 that will close this issue
parcel typechecking and initial setup for automated tests #39
Merged
@warengonzaga warengonzaga added chore Issue/Pull Request Label for Housekeeping and removed in progress Issue/Pull Request Label for In Progress Status labels Dec 11, 2021
@warengonzaga
Copy link
Owner

Closing this issue now as per #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@princejoogie princejoogie

Labels
chore Issue/Pull Request Label for Housekeeping tweak Issue/Pull Request for Tweaks
Projects
None yet
Milestone
v1.0.0 Beta 🌱
Development

Successfully merging a pull request may close this issue.

parcel typechecking and initial setup for automated tests
3 participants
@jofftiquez @warengonzaga @princejoogie