fix: use stable Agave v3.1 validator in CI#477
Conversation
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 8 minutes and 48 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo validator-related shell scripts were updated: one modifies the GitHub API query for fetching latest releases with pagination and updated version prefix, while the other removes a deprecated RPC flag from the test validator startup command. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
wallet-ui-docs | 612d8cd | Apr 13 2026, 07:41 PM |
BundleMonUnchanged files (19)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
Deploying react-vite-tailwind with
|
| Latest commit: |
a154f4e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://db4ab02d.react-vite-tailwind.pages.dev |
| Branch Preview URL: | https://beeman-validator-v3-1-ci-fix.react-vite-tailwind.pages.dev |
@wallet-ui/core
@wallet-ui/css
@wallet-ui/react
@wallet-ui/react-native-kit
@wallet-ui/react-native-web3js
@wallet-ui/tailwind
commit: |
beeman
force-pushed
the
beeman/validator-v3-1-ci-fix
branch
from
483f9ba to
a154f4e
Compare
Request more GitHub release results, switch CI to the stable Agave v3.1.x line, and stop passing the block subscription flag that panics under solana-test-validator v3.1.13.
beeman
force-pushed
the
beeman/validator-v3-1-ci-fix
branch
from
a154f4e to
612d8cd
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| set -e | ||
| version=$(node -e \ | ||
| 'fetch("https://api.github.com/repos/anza-xyz/agave/releases").then(res => res.json().then(rs => rs.filter(r => !r.prerelease && r.tag_name.startsWith("v2.3."))).then(x => console.log(x[0].tag_name)));' | ||
| 'fetch("https://api.github.com/repos/anza-xyz/agave/releases?per_page=100").then(res => res.json().then(rs => rs.filter(r => !r.prerelease && r.tag_name.startsWith("v3.1."))).then(x => console.log(x[0].tag_name)));' |
There was a problem hiding this comment.
🚩 Major version jump from v2.3 to v3.1 — verify compatibility
The validator version filter changed from v2.3. to v3.1., which is a major version bump. The ?per_page=100 addition is a good improvement to ensure the filtered version appears in the results. However, a jump from v2.x to v3.x may introduce breaking changes in the test validator's behavior, CLI flags, or RPC API. This is worth verifying that all live tests still pass against the new validator version. The removal of --rpc-pubsub-enable-block-subscription in the other script may itself be a consequence of this flag being removed or changed in v3.1.
Was this helpful? React with 👍 or 👎 to provide feedback.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@scripts/start-shared-test-validator.sh`:
- Line 27: The validator launch line uses unquoted variable expansions which can
break on spaces or glob characters; update the background command that invokes
TEST_VALIDATOR to quote the variables (e.g., use "$TEST_VALIDATOR", --ledger
"$TEST_VALIDATOR_LEDGER", and --account-dir "$FIXTURE_ACCOUNTS_DIR") while
keeping the same flags (--reset, --quiet, --rpc-pubsub-enable-vote-subscription)
and redirection (>/dev/null &) so the command is robust to spaces and special
characters.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b8ce20ef-b551-4f68-959e-04ca5bcac31f
📒 Files selected for processing (2)
scripts/get-latest-validator-release-version.shscripts/start-shared-test-validator.sh
| ( | ||
| if flock -nx 200; then | ||
| $TEST_VALIDATOR --ledger $TEST_VALIDATOR_LEDGER --reset --quiet --account-dir $FIXTURE_ACCOUNTS_DIR --rpc-pubsub-enable-vote-subscription --rpc-pubsub-enable-block-subscription >/dev/null & | ||
| $TEST_VALIDATOR --ledger $TEST_VALIDATOR_LEDGER --reset --quiet --account-dir $FIXTURE_ACCOUNTS_DIR --rpc-pubsub-enable-vote-subscription >/dev/null & |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Read the script to see the context around line 27
cat -n scripts/start-shared-test-validator.sh | head -40Repository: wallet-ui/wallet-ui
Length of output: 2095
🏁 Script executed:
# Check if variables are defined in the script and how they're typically used
rg -n '\$TEST_VALIDATOR|\$TEST_VALIDATOR_LEDGER|\$FIXTURE_ACCOUNTS_DIR' scripts/start-shared-test-validator.shRepository: wallet-ui/wallet-ui
Length of output: 399
🏁 Script executed:
# Check if there are similar patterns in other shell scripts in the repo
fd -e sh -type f | head -20Repository: wallet-ui/wallet-ui
Length of output: 233
Quote variable expansions in the validator launch command.
Line 27 uses unquoted variable expansions that can break with spaces or glob characters in paths. The variables are already quoted in the conditional check on line 14, so this should be consistent throughout the script.
Suggested fix
- $TEST_VALIDATOR --ledger $TEST_VALIDATOR_LEDGER --reset --quiet --account-dir $FIXTURE_ACCOUNTS_DIR --rpc-pubsub-enable-vote-subscription >/dev/null &
+ "$TEST_VALIDATOR" --ledger "$TEST_VALIDATOR_LEDGER" --reset --quiet --account-dir "$FIXTURE_ACCOUNTS_DIR" --rpc-pubsub-enable-vote-subscription >/dev/null &📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| $TEST_VALIDATOR --ledger $TEST_VALIDATOR_LEDGER --reset --quiet --account-dir $FIXTURE_ACCOUNTS_DIR --rpc-pubsub-enable-vote-subscription >/dev/null & | |
| "$TEST_VALIDATOR" --ledger "$TEST_VALIDATOR_LEDGER" --reset --quiet --account-dir "$FIXTURE_ACCOUNTS_DIR" --rpc-pubsub-enable-vote-subscription >/dev/null & |
🧰 Tools
🪛 Shellcheck (0.11.0)
[info] 27-27: Double quote to prevent globbing and word splitting.
(SC2086)
[info] 27-27: Double quote to prevent globbing and word splitting.
(SC2086)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@scripts/start-shared-test-validator.sh` at line 27, The validator launch line
uses unquoted variable expansions which can break on spaces or glob characters;
update the background command that invokes TEST_VALIDATOR to quote the variables
(e.g., use "$TEST_VALIDATOR", --ledger "$TEST_VALIDATOR_LEDGER", and
--account-dir "$FIXTURE_ACCOUNTS_DIR") while keeping the same flags (--reset,
--quiet, --rpc-pubsub-enable-vote-subscription) and redirection (>/dev/null &)
so the command is robust to spaces and special characters.
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
1 participant
Request more GitHub release results and switch the validator lookup to the stable v3.1.x line so the installer URL resolves again.
Summary by CodeRabbit