Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error performing complete update (array in authors) #818

Closed
ngosang opened this issue Aug 25, 2019 · 9 comments
Closed

Error performing complete update (array in authors) #818

ngosang opened this issue Aug 25, 2019 · 9 comments
Labels

Comments

@ngosang
Copy link
Contributor

ngosang commented Aug 25, 2019

Issue details

I built the apk from master (to test #811) and when I perform a complete update in the app. I see this error.

Screenshot_2019-08-25-23-09-04-683_fr gaulupeau apps InThePoche debug

Environment details

@tcitworld tcitworld added the Bug label Aug 25, 2019
@ngosang
Copy link
Contributor Author

ngosang commented Aug 25, 2019

@tcitworld I think this is important, I can't use the app because I can't update. I'm going to a previous version by now. I will test again if you release some fix.

@di72nn
Copy link
Member

di72nn commented Aug 26, 2019

That's a long shot, but can you run this on your server?

select id, url, published_by from wallabag_entry where published_by like '%;a:%';

// Update: I'm able to see the exactly same error if I manipulate an entry to have another array inside of authors array.

@ngosang
Copy link
Contributor Author

ngosang commented Aug 26, 2019

@di72nn bingo!

id = 629
url = https://www.newyorker.com/magazine/2016/02/29/a-new-generation-of-airships-is-born?mbid=rss
published_by = a:1:{i:0;a:1:{i:0;s:19:"Jeanne Marie Laskas";}}

Btw, in wallabag web I see just Array
image

@Kdecherf
Copy link
Member

Kdecherf commented Aug 26, 2019

Could be related to wallabag/wallabag#3867 (edit: I should read better 😅)

By the way, the Array does not show up anymore on current server master

@di72nn
Copy link
Member

di72nn commented Aug 26, 2019

I guess the extraction was fixed.

To make the error searchable: Error: com.squareup.moshi.JsonDataException: Expected a string but was BEGIN_ARRAY at path $._embedded.items[29].pubulished_by[0].

Thanks for the report, maybe it'll help someone else!

@di72nn di72nn closed this as completed Aug 26, 2019
@di72nn di72nn changed the title Error performing complete update (master) Error performing complete update (array in authors) Aug 26, 2019
@ngosang
Copy link
Contributor Author

ngosang commented Aug 26, 2019

@di72nn is fixed in wallabag app or in wallabag web?

@di72nn
Copy link
Member

di72nn commented Aug 26, 2019

That just shouldn't happen. Refetch the article (on the server) and the problem should be gone. I think the extraction rule was broken in the past or something like that.

@ngosang
Copy link
Contributor Author

ngosang commented Aug 26, 2019

@di72nn how is that? I have my own server, if I don't update the server or something I get the same result, Array...
Edit: don't worry, it's not that important. i will fix manually

@di72nn
Copy link
Member

di72nn commented Aug 26, 2019

The entry in question was fetched with older server version (in the early 2017), if you refetch it with 2.3.8, the field should update with the correct value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants