Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] create public links #742

Open
ghost opened this issue Nov 3, 2018 · 12 comments
Open

[feature request] create public links #742

ghost opened this issue Nov 3, 2018 · 12 comments
Labels

Comments

@ghost
Copy link

ghost commented Nov 3, 2018

It would be nice to be able to create public links similar to the web interface.

@Strubbl Strubbl added the Feature label Nov 4, 2018
@Strubbl
Copy link
Contributor

Strubbl commented Nov 4, 2018

Good suggestion. Do you have an idea how it should be possible? I mean w.r.t. the user interface. How shall a user reach this feature?

@ghost
Copy link
Author

ghost commented Nov 21, 2018

In the articles setting is one choise Copy original URL and there I would expect also a choise like Create Public URL or something similar.

@Strubbl
Copy link
Contributor

Strubbl commented Nov 21, 2018

And after selecting that menu option?

Shall the public link URL be available in the app somehow or does it not matter what the public URL is? Or just a toast message with or without the link URL?

@ghost
Copy link
Author

ghost commented Nov 21, 2018

I would expect the same behavior as the copy original URL function has: that the URL is now copied to the clipboard. That would fit my specific usecase.

But in my opinion there could be in addition also the option to choose would URL gets shared when the share button is selected

Thanks for your interest and your questions, that helps a lot understanding what I want ;)

@biva
Copy link

biva commented Feb 27, 2021

Hello, any news about this feature? It would be great!

To make it easy, I would just add a button in the menu, below the existing "Share" button. The list of actions would be:
Share original link
Share public link
Modify the title
...
Thanks in advance!

@retiolus
Copy link
Contributor

retiolus commented Nov 1, 2022

Any news about this feature? For me, this is one of the most important things that is missing... I have to open the web interface every time.

@Strubbl
Copy link
Contributor

Strubbl commented Nov 1, 2022

I am not sure if the API does expose a method to implement this feature. Am i overlooking anything? https://app.wallabag.it/api/doc

@di72nn
Copy link
Member

di72nn commented Nov 1, 2022

There's a public flag with description "will generate a public link for the entry" on PATCH /api/entries/{entry} and there's a field allowing to construct a public link.
Shouldn't be a lot of work, mostly implementing UI, but I haven't gotten around to doing it.

@retiolus
Copy link
Contributor

retiolus commented Nov 2, 2022

I tried to add this option but so far it only works when the article has already been made public once through the web interface.

case R.id.menuCopyPublicURL:
                article.setIsPublic(Boolean.TRUE);
                copyUrlToClipboard(activity, url + "/share/" + article.getPublicUid());
                return true;

I don't quite understand what article.setIsPublic(Boolean.TRUE); does, since it doesn't make the article public.

image

@matt-wirth
Copy link

This would be a huge benefit to my workflow, thanks everyone for working on this!

@freakshock88
Copy link

It seems the web app just calls URL https://mywallabaginstance.com/share/{articleid}.
It then forwards you to the publicly available url.
Shouldn't the app also be able to to something similar (catching the resulting url and copying to clipboard?)

@retiolus
Copy link
Contributor

retiolus commented Feb 4, 2025

Hi, what about implementing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants