Adjust images size according to the screen

[El-Gavy]

Images (and their captions) are not adjusted to the screen width (using Wallabag App 1.12.2 (32)) :

[di72nn]

Can you include the article URL as an example?

[El-Gavy]

Sure. Here is the article URL of the screenshot above : https://framablog.org/2017/03/27/le-transit-cest-important-%f0%9f%99%82/

[di72nn]

Do you use wallabag.it, framabag, or a self-hosted server? I ask because the responsive parameters of the images may be handled differently.

[El-Gavy]

I use a self hosted server. Do you need the server version ?

[Strubbl]

yes

[El-Gavy]

2.2.1

[di72nn]

Do you have "image caching" enabled in the app? Can you try to toggle it and check the same article?

[El-Gavy]

Image caching was enabled :

I toggled it, deleted the article in "Archives", closed the app, added the same article using my web browser (still on my smartphone).
Re-opening and checking the article, result is the same as previously.

Hoping that help.

[Strubbl]

There have been 138 commits to master since your version. To cite @di72nn: Maybe "you might want to try our beta version. You can opt-in for beta-testing on GPlay or download an APK."

[di72nn]

Well, yeah. It is likely to be reproducible in the beta, but at least we will be sure it wasn't fixed recently.

I can't reproduce it on my device (Android 4.4, small screen): for some reason it is displayed ok regardless of app version and image caching.

I'm not into HTML, so I have a hard time understanding why this happens.

[Strubbl]

I couldn't reproduce it on my old Nexus 7 running the wallabag version installed from F-droid, so same version as @El-Gavy . On my mobile it is also not reproducible. :(

[El-Gavy]

Trying to upgrade right now, coming back to you when done (hoping it goes well)

[El-Gavy]

I don't know how i did this :

I selected one of the themes and it's ok now.

[Strubbl]

Cool that it is okay now.

So you had no theme pre-selected? That's crazy behaviour of the app. If i go to that menu, i have my theme preselected.

[El-Gavy]

Well i'm sure i changed the theme at least once since installed. But maybe i was this way because of an update ?

[di72nn]

The theme selection dialog acts weird because of this: d3e3b95 (the value stored in preferences doesn't match the enum name). I should have added a migration, but I've forgotten and it doesn't really matter. It can only reset theme to the default one and cause the dialog to show no selected option. It should work fine after any theme is selected.

Back to the original issue. Is it still there?

[El-Gavy]

Ok, here we are :

• On my android, i upgraded Wallabag App to Version 2.0.0a3 (102)
• On my shared hosting, using FTP, i wiped my install, backing up only app/config/parameters.yml and /data. I uploaded version 2.2.2 and put back elements quoted before. Didn't know if it was necessary to clear var/cache folder.

The install looks ok, except i have this issue : wallabag/wallabag#3006 (always have it when i install wallabag, dunno why). The link server / app is working

Still have the issue, whereas it's ok with other articles...

Tried to delete article from app, disabled image cache then adding it again, still the issue.

However, i'm starting to strongly suspect a chair / keyboard interface problem...

[di72nn]

Here are some things that should be noted:

• The server can fetch article differently. That probably can be checked with web tools in a web browser. I'm not aware of any way to subtly break article fetching on the server side.
• Depending on the app version the articles are downloaded differently: via RSS in the older version, via API in the beta. It seems to have no affect on the issue.
• If image caching is enabled, the app strips responsive parameters from img tags. This is important, but seems to have no affect here so far.
• The app uses Android WebView to display article content. The behavior may vary depending on Android version and possibly OEM customization.
• Device characteristics (screen size, DPI, etc.) may have affect on responsive parameters handling.

Something in the last two points is likely to cause the problem.

Please state your Android version, device manufacturer, screen size and maybe something else that you think may be related.

This part of the app wasn't changed in a while and nobody mentioned such an issue, so either no one cares, or it is very rare.

[El-Gavy]

Well i'm giving the infos, in case that could be useful later but i agree that it's rare, even on my device, it doesn't affect most of the articles. For instance, i checked other articles from the same website and images are fine.

Huawei KIW-L21 (Honor 5X)
EMUI 4.0
Android 6.0.1
1080*1920

[Strubbl]

Tried to delete article from app, disabled image cache then adding it again, still the issue.

On deleting an article in the app, the cached images are not removed from SD card AFAIK. But this should not affect the display issue here, i guess. Because in your screenshot it looks like the original image is cached successfully and is displayed in this original size.

[Strubbl]

do you have image caching enabled in your wallabag server?

[Strubbl]

is the image with the cat the only one which is wrongly sized displayed in the app? Or is the internet map image (the first one) also wrongly scaled?

[El-Gavy]

All images of the article are wrongly sized.

Image caching is enabled on server (« 1 »)

[Strubbl]

Okay, thanks for the additional information. It would be really nice to see the debug messages of the app in that case.

[El-Gavy]

Sure.

... ok, i have no idea where to find those debug messages xD

[di72nn]

Image caching is enabled on server (« 1 »)

I totally forgot about it. That can break the content (responsive parameters are stripped?) too.

[ngosang]

I'm having the image size problem in some images. I think the easy way to fix it is remove "width" & "height" attributes from "img" tag.