fix(vercel): emit platform data (#1226)

close #1225

Author: dai-shi

packages/waku/src/lib/builder/build.ts

@@ -7,11 +7,7 @@ import type { LoggingFunction, RollupLog } from 'rollup';
 import type { ReactNode } from 'react';
 
 import type { Config } from '../../config.js';
-import {
-  INTERNAL_setAllEnv,
-  INTERNAL_iterateSerializablePlatformData,
-  unstable_getBuildOptions,
-} from '../../server.js';
+import { INTERNAL_setAllEnv, unstable_getBuildOptions } from '../../server.js';
 import type { EntriesPrd } from '../types.js';
 import type { ResolvedConfig } from '../config.js';
 import { resolveConfig } from '../config.js';
@@ -65,6 +61,7 @@ import { deployCloudflarePlugin } from '../plugins/vite-plugin-deploy-cloudflare
 import { deployDenoPlugin } from '../plugins/vite-plugin-deploy-deno.js';
 import { deployPartykitPlugin } from '../plugins/vite-plugin-deploy-partykit.js';
 import { deployAwsLambdaPlugin } from '../plugins/vite-plugin-deploy-aws-lambda.js';
+import { emitPlatformData } from './platform-data.js';
 
 // TODO this file and functions in it are too long. will fix.
 
@@ -765,36 +762,6 @@ export async function build(options: {
   delete buildOptions.unstable_phase;
 
   if (existsSync(distEntriesFile)) {
-    const DIST_PLATFORM_DATA = 'platform-data';
-    const keys = new Set<string>();
-    await mkdir(joinPath(rootDir, config.distDir, DIST_PLATFORM_DATA), {
-      recursive: true,
-    });
-    for (const [key, data] of INTERNAL_iterateSerializablePlatformData()) {
-      keys.add(key);
-      const destFile = joinPath(
-        rootDir,
-        config.distDir,
-        DIST_PLATFORM_DATA,
-        key + '.js',
-      );
-      await writeFile(destFile, `export default ${JSON.stringify(data)};`);
-    }
-    await appendFile(
-      distEntriesFile,
-      `
-export function loadPlatformData(key) {
-  switch (key) {
-    ${Array.from(keys)
-      .map(
-        (k) =>
-          `case '${k}': return import('./${DIST_PLATFORM_DATA}/${k}.js').then((m) => m.default);`,
-      )
-      .join('\n')}
-    default: throw new Error('Cannot find platform data: ' + key);
-  }
-}
-`,
-    );
+    await emitPlatformData(joinPath(rootDir, config.distDir));
   }
 }

packages/waku/src/lib/builder/platform-data.ts

@@ -0,0 +1,34 @@
+import { INTERNAL_iterateSerializablePlatformData } from '../../server.js';
+import { joinPath } from '../utils/path.js';
+import { appendFile, mkdir, writeFile } from '../utils/node-fs.js';
+import { DIST_ENTRIES_JS } from './constants.js';
+
+const DIST_PLATFORM_DATA = 'platform-data';
+
+export const emitPlatformData = async (distDir: string) => {
+  const keys = new Set<string>();
+  await mkdir(joinPath(distDir, DIST_PLATFORM_DATA), {
+    recursive: true,
+  });
+  for (const [key, data] of INTERNAL_iterateSerializablePlatformData()) {
+    keys.add(key);
+    const destFile = joinPath(distDir, DIST_PLATFORM_DATA, key + '.js');
+    await writeFile(destFile, `export default ${JSON.stringify(data)};`);
+  }
+  await appendFile(
+    joinPath(distDir, DIST_ENTRIES_JS),
+    `
+export function loadPlatformData(key) {
+  switch (key) {
+    ${Array.from(keys)
+      .map(
+        (k) =>
+          `case '${k}': return import('./${DIST_PLATFORM_DATA}/${k}.js').then((m) => m.default);`,
+      )
+      .join('\n')}
+    default: throw new Error('Cannot find platform data: ' + key);
+  }
+}
+`,
+  );
+};

packages/waku/src/lib/plugins/vite-plugin-deploy-cloudflare.ts

@@ -1,6 +1,5 @@
 import { randomBytes } from 'node:crypto';
 import {
-  appendFileSync,
   copyFileSync,
   existsSync,
   mkdirSync,
@@ -13,11 +12,9 @@ import path from 'node:path';
 
 import type { Plugin } from 'vite';
 
-import {
-  INTERNAL_iterateSerializablePlatformData,
-  unstable_getBuildOptions,
-} from '../../server.js';
-import { DIST_ENTRIES_JS, DIST_PUBLIC } from '../builder/constants.js';
+import { emitPlatformData } from '../builder/platform-data.js';
+import { unstable_getBuildOptions } from '../../server.js';
+import { DIST_PUBLIC } from '../builder/constants.js';
 import { SRC_ENTRIES } from '../constants.js';
 
 const SERVE_JS = 'serve-cloudflare.js';
@@ -193,7 +190,7 @@ export function deployCloudflarePlugin(opts: {
         return getServeJsContent(entriesFile);
       }
     },
-    closeBundle() {
+    async closeBundle() {
       const { deploy, unstable_phase } = buildOptions;
       if (unstable_phase !== 'buildDeploy' || deploy !== 'cloudflare') {
         return;
@@ -210,36 +207,7 @@ export function deployCloudflarePlugin(opts: {
         functionDir: workerDistDir,
       });
 
-      const DIST_PLATFORM_DATA = 'platform-data';
-      const keys = new Set<string>();
-      mkdirSync(path.join(workerDistDir, DIST_PLATFORM_DATA), {
-        recursive: true,
-      });
-      for (const [key, data] of INTERNAL_iterateSerializablePlatformData()) {
-        keys.add(key);
-        const destFile = path.join(
-          workerDistDir,
-          DIST_PLATFORM_DATA,
-          key + '.js',
-        );
-        writeFileSync(destFile, `export default ${JSON.stringify(data)};`);
-      }
-      appendFileSync(
-        path.join(workerDistDir, DIST_ENTRIES_JS),
-        `
-export function loadPlatformData(key) {
-  switch (key) {
-    ${Array.from(keys)
-      .map(
-        (k) =>
-          `case '${k}': return import('./${DIST_PLATFORM_DATA}/${k}.js').then(m => m.default);`,
-      )
-      .join('\n')}
-    default: throw new Error('Cannot find platform data: ' + key);
-  }
-}
-`,
-      );
+      await emitPlatformData(workerDistDir);
 
       const wranglerTomlFile = path.join(rootDir, 'wrangler.toml');
       if (!existsSync(wranglerTomlFile)) {

packages/waku/src/lib/plugins/vite-plugin-deploy-vercel.ts

@@ -5,6 +5,7 @@ import type { Plugin } from 'vite';
 import { unstable_getBuildOptions } from '../../server.js';
 import { SRC_ENTRIES } from '../constants.js';
 import { DIST_PUBLIC } from '../builder/constants.js';
+import { emitPlatformData } from '../builder/platform-data.js';
 
 const SERVE_JS = 'serve-vercel.js';
 
@@ -84,7 +85,7 @@ export function deployVercelPlugin(opts: {
         return getServeJsContent(opts.distDir, DIST_PUBLIC, entriesFile);
       }
     },
-    closeBundle() {
+    async closeBundle() {
       const { deploy, unstable_phase } = buildOptions;
       if (
         unstable_phase !== 'buildDeploy' ||
@@ -112,6 +113,7 @@ export function deployVercelPlugin(opts: {
           path.join(serverlessDir, opts.distDir),
           { recursive: true },
         );
+        await emitPlatformData(path.join(serverlessDir, opts.distDir));
         if (existsSync(path.join(rootDir, opts.privateDir))) {
           cpSync(
             path.join(rootDir, opts.privateDir),