Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrator "ambientocclusion" #10

Closed
wahn opened this issue Jul 19, 2017 · 1 comment
Closed

Integrator "ambientocclusion" #10

wahn opened this issue Jul 19, 2017 · 1 comment
Assignees
Labels

Comments

@wahn
Copy link
Owner

wahn commented Jul 19, 2017

By replacing the directlighting integrator (using default values) within the Cornell Box scene we get:

pbrt_cpp

On the C++ side this is handled in RenderOptions::MakeIntegrator():

Integrator *RenderOptions::MakeIntegrator() const {
...
    if (IntegratorName == "whitted")
        integrator = CreateWhittedIntegrator(IntegratorParams, sampler, camera);
...
    else if (IntegratorName == "directlighting")
        integrator =
            CreateDirectLightingIntegrator(IntegratorParams, sampler, camera);
...
    } else if (IntegratorName == "ambientocclusion") {
        integrator = CreateAOIntegrator(IntegratorParams, sampler, camera);
...
    }
...
}
@wahn wahn added the task label Jul 19, 2017
@wahn wahn self-assigned this Jul 19, 2017
@wahn
Copy link
Owner Author

wahn commented Jul 27, 2017

Commit e0ef343 should render exactly the same image as the C++ counterpart:

pbrt

Closing the issue for now ...

@wahn wahn closed this as completed Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant